-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adding in Noise Profiles for the Pixii A2572 camera. #18748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adding in Noise Profiles for the Pixii A2572 camera. #18748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I think your pattern has not a good transition to the pure white. The graph starting at 3200 ISO is quote chaotic to me.
See the green curve that should be mostly straight, here at 0.5 the oscillation are possibly wrong:
Could you try with a pattern with a better transition from mid-light to pure white?
Comes from here I think: Lines 332 to 335 in 8d1ccdb
If there is a strong preference, we could potentially introduce a normalization in RawSpeed ('PIXII SAS' -> 'Pixii' w/ 'Pixii Camera (A2572)' -> 'A2572'), i.e. along the lines of what is done for Leicas? OTOH, we already didn't prettify some other less known brands like 'Raspberrypi' and 'YI TECHNOLOGY'... In any case, would you mind uploading a sample to https://raw.pixls.us/ and/or share one via a file transfer link? |
Sure thing. It may take a few days, but I'll get an update pushed. |
Will do. I don't have a file that fits the criteria yet (daylight, well lit, low ISO file that hasn't been touched by anything else), but I will take some this weekend and get them uploaded. Brand new camera to me and just starting to get all of this organized. |
Added in a set of noise profiles to the noiseprofiles.json file for the Pixii A2572 camera. I also added the maker of 'PIXII SAS' to the noiseprofiles.schema file after my checks failed.
One note is that I had to manually change the name for the "maker" from 'Pixii' to 'PIXII SAS' to get darktable to automatically link the profile to the image in the develop module. This is on line 7925 of the changed file.
darktable-noiseprofile-20250501.tar.gz