Build older exiv2 in Windows nightly since it is no longer installable from the archive #18981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The required older (Windows wide string compatible) version of exiv2 is no longer available in the MSYS2 archive repository
|
@TurboGit It would be good to merge, as nightly is currently failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required older (Windows wide-string compatible) version of exiv2 is no longer available in the MSYS2 archive repository.
While we can build the latest wide-string compatible version of exiv2 indefinitely, it is still a temporary hack. Eventually, there will be important additions/fixes to exiv2 that will not be backported to the 0.27.x branch.
So sooner or later we will have to switch from wstring to UTF-8 for compatibility with exiv2 0.28+ by merging #15899.
I suggest doing this as early as possible in the 5.4 development cycle (i.e., right now) to have as much time for testing as possible.