Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently, the default theme is darktable-elegant-grey #620

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

victoryforce
Copy link
Contributor

After accepting darktable-org/darktable#11936 the default theme is darktable-elegant-grey.

@elstoc elstoc added this to the 4.8 milestone Feb 2, 2024
@elstoc
Copy link
Contributor

elstoc commented Apr 20, 2024

On second thoughts this change is not correct. While the default theme is darktable-elegant-grey, the bulk of the css remains in darktable.css, so this needs some rewording as well.

@victoryforce
Copy link
Contributor Author

I see. Indeed. What would be your suggestion for change? I think we could just remove the phrase about where most of the css code is located.

@elstoc
Copy link
Contributor

elstoc commented Apr 21, 2024

Since this section is more about how the themes are constructed, I might be tempted to go the other way - i.e. remove the bit about the default theme and change it to say that darktable.css is where most of the css code is located.

@victoryforce
Copy link
Contributor Author

You are right. Done.

@elstoc
Copy link
Contributor

elstoc commented Apr 22, 2024

LGTM

@elstoc elstoc merged commit 914ef93 into darktable-org:master Apr 22, 2024
1 check passed
@victoryforce victoryforce deleted the new-default-theme branch April 22, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants