Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document descriptions for color labels #707

Conversation

kofa73
Copy link
Contributor

@kofa73 kofa73 commented Dec 27, 2024

Please include a link to the Pull Request that you are documenting

For darktable-org/darktable#16139.

Tell us a little bit about this pull request

Added a short description mentioning the right-click to assign a description.

Note: is the label shown anywhere? I know it's shown in the tooltip (here: experiment):
image

But e.g. in filters, only the colour is shown:
image
Same for the filter:
image

@kofa73 kofa73 changed the title Update lighttable-view-layout.md Document descriptions for color labels Dec 27, 2024
@elstoc
Copy link
Contributor

elstoc commented Jan 1, 2025

yes I think it's just in the tooltip. As I said in the PR, it seems pretty pointless functionality to me. It's probably worth mentioning that (the assigned name appears in the tooltip) as part of this PR.

@victoryforce
Copy link
Contributor

yes I think it's just in the tooltip.

In the tooltip of buttons only, yes. Thanks for your attention, @kofa73! Indeed, it would be logical to add a custom description of the color labels in other places as well.

As I said in the PR, it seems pretty pointless functionality to me.

I personally don't use color labels much, but I know people who are very happy with this improvement.

Unlike rating stars, colors do not have any natural connection to the quality or status of the image. Each user invents this to their own taste, often experimenting to find the most useful model for themselves. A reminder of the semantics they settled on is a useful thing.

Yes, of course, implementing this through global settings was a suboptimal idea, here I fully support you.

By the way, Lightroom also supports assigning different semantics to color labels.

@kofa73
Copy link
Contributor Author

kofa73 commented Jan 4, 2025

OK. Anything I should change in the description? As it stands, I think it documents the current state. Please let me know if you something is blocking a merge.

@elstoc
Copy link
Contributor

elstoc commented Jan 4, 2025

Yes I asked you to add some wording:

It's probably worth mentioning that (the assigned name appears in the tooltip) as part of this PR.

@kofa73
Copy link
Contributor Author

kofa73 commented Jan 5, 2025

Yes I asked you to add some wording:

OK, thanks; done.

@elstoc
Copy link
Contributor

elstoc commented Jan 5, 2025

LGTM thanks

@elstoc elstoc merged commit 664515a into darktable-org:master Jan 5, 2025
1 check passed
@kofa73 kofa73 deleted the kofa73-color-label-descriptions-for-pr-16139 branch January 7, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants