Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC5Decompressor: support GoPro HERO10 CFA pattern #308

Closed
wants to merge 1 commit into from

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Sep 30, 2021

Proposal for addressing darktable-org/darktable#10072

@kmilos kmilos requested a review from LebedevRI as a code owner September 30, 2021 13:35
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #308 (ca562fe) into develop (67849c7) will decrease coverage by 0.02%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #308      +/-   ##
===========================================
- Coverage    60.03%   60.01%   -0.03%     
===========================================
  Files          235      235              
  Lines        12715    12722       +7     
  Branches      1757     1758       +1     
===========================================
+ Hits          7634     7635       +1     
- Misses        4952     4957       +5     
- Partials       129      130       +1     
Flag Coverage Δ
integration 47.69% <50.00%> (-0.02%) ⬇️
rpu_u 47.69% <50.00%> (-0.02%) ⬇️
unittests 22.73% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/librawspeed/decompressors/VC5Decompressor.cpp 74.84% <45.45%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67849c7...ca562fe. Read the comment docs.

@LebedevRI
Copy link
Member

Thank you for confirming my suspicions, but that is not the fix i envision.

@kmilos
Copy link
Collaborator Author

kmilos commented Oct 1, 2021

Sure, just wanted to share the minimal working test...

@kmilos kmilos closed this Oct 1, 2021
@kmilos kmilos deleted the gopro_hero10 branch October 1, 2021 13:51
@arbasel
Copy link

arbasel commented Oct 1, 2021

Given that this is closed, is there something that I can do so that my GoPro photos open correctly in Darktable?

@ghost
Copy link

ghost commented May 7, 2022

@kmilos Is this not getting fixed for GoPro HERO10 RAW files?

@kmilos kmilos restored the gopro_hero10 branch June 9, 2022 12:32
@kmilos kmilos deleted the gopro_hero10 branch June 9, 2022 13:34
@kmilos kmilos restored the gopro_hero10 branch June 9, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants