-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not throw if DNG crop is undefined (DJI bug) #475
base: develop
Are you sure you want to change the base?
Conversation
2af2cd0
to
9c3e400
Compare
Yeah i do not know about this... I guess they expect us to treat This is quite an unfortunate situation. |
I don't think we can assume that. For example, DJI really put (0/0, 0/0) in there, so for DefaultCropSize we can't and should not pretend it is (0,0).
The Exif (or TIFF/EP) spec mentions for some fields that 0/0 means "undefined".
It is unfortunate, but I think falling back to default (entire image) is sensible in this specific case, instead of bailing out on the user. We do something similar already if the opcodes cannot be properly parsed (i.e. just ignore them, but not bail out)... |
Yep, the Exif spec mentions in several places:
|
This doesn't work yet btw, because |
Argh, they also put ActiveArea as 0 0 0 0. Wonderful! |
9c3e400
to
c169765
Compare
c169765
to
4af507a
Compare
Why do we care to support those invalid files? |
To allow users to process files captured by their (invalid) equipment |
4af507a
to
227d516
Compare
The file is probably usable, so fall back to default values and log error instead
227d516
to
c44a6ad
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #475 +/- ##
===========================================
- Coverage 59.06% 59.04% -0.02%
===========================================
Files 232 232
Lines 13813 13824 +11
Branches 1932 1933 +1
===========================================
+ Hits 8159 8163 +4
- Misses 5521 5528 +7
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
let me check |
Looks like both |
The file is probably usable, so fall back to default values and log error instead.
This should address darktable-org/darktable#11949 and https://discuss.pixls.us/t/unable-to-import-drone-hyperlapse-images/37222
Asked for samples...