Rewrite darling_thread_entry Inline Assembly #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
CuriousTommy
force-pushed
the
mldr_thread_entry_rework
branch
from
27fe5f8 to
2ded39e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
CuriousTommy
force-pushed
the
mldr_thread_entry_rework
branch
2 times, most recently
from
0549204 to
c036704
Compare
CuriousTommy
changed the title
|
@bugaevc and @facekapow: If you have the freetime, can you check my PR? Since I'm not too familiar with x86/x86_64 assembly, I want to make sure it looks good before I merge the changes in. |
facekapow
approved these changes
Sep 7, 2023
CuriousTommy
force-pushed
the
mldr_thread_entry_rework
branch
2 times, most recently
from
6eaf40e to
b92e59c
Compare
From the discussion in Discord, there are some strange/potentionally problematic design choices with the current inline assembly code. To take advantage of the GNU register asm(...) feature, the std version need to be set to gnu11, instead of c11.
CuriousTommy
force-pushed
the
mldr_thread_entry_rework
branch
from
b92e59c to
44ccee6
Compare
CuriousTommy
force-pushed
the
mldr_thread_entry_rework
branch
from
44ccee6 to
2c0c72d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion in Discord, there are some strange/potentially problematic design choices with the current inline assembly code. This PR rewrites the problematic assembly code and documents what the assembly code is trying to do.
In addition to the assembly fix, the
archexecutable is also updated to allow running universal binaries in i386 mode.