New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #235

Open

voraczech wants to merge 1 commit into darrenjennings:master from voraczech:master

voraczech commented Jan 10, 2023

What: Changing documentation appropriately - shouldRenderSuggestions (should-render-suggestions) does not return true if there is 0 results.

Why: shouldRenderSuggestions shows only if there is any result but not when 0

shouldRenderSuggestions: {
      type: Function,
      required: false,
      default: (totalResults, loading) => {
        return totalResults > 0 && !loading;
      }
},

How: changing docs (rather than code)

Checklist:

Documentation
N/A Tests
Ready to be merged
N/A Added myself to contributors table


          Update README.md

f5bac38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet