-
Notifications
You must be signed in to change notification settings - Fork 248
Update Angular to use package:observable #1761
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Approval.
Weird - https://pub.dartlang.org/packages/observe is on version 0.14.0 |
Looks like this needs to wait until an update to polymer is published dart-archive/polymer-expressions#9 |
Actually, the problem seems to be with the introduction of the dependency on package:test (via package:observable and package:observe). |
wtf?
|
Huh, I actually get the following error trying to run
|
There's a version tangle here that I don't have time to work through. If someone wants to land this PR, they'll have to update some version dependencies in pubspec.yaml |
I think it's OK to keep Angular Dart 1 using the deprecated package for the time being - we aren't expecting any new users and old users are moving to Angular Dart 2. |
No description provided.