This repository has been archived by the owner on Nov 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for running perftools to use hardware performance counters when benchmarking. #98
Add support for running perftools to use hardware performance counters when benchmarking. #98
Changes from 12 commits
f212528
8a2c57f
3010760
c7a2166
bb86037
0176c8a
73f42b0
a9858d9
11d8eab
221124a
166a5b8
a687636
be1a2c4
931e4e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you need to write a CHANGELOG entry about this new feature and bump the minor version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this is its own method? Perhaps it might be nicer with a utility function to make a singular fifo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's nicer to use the = syntax so each option is on its own line
E.g. --delay=-1 --control=fifo:... --pid=$pid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to check if this message is actually written and throw if not?