-
Notifications
You must be signed in to change notification settings - Fork 17
Updated to latest Unicode spec 15.1.0 and set version to 1.4.0 #95
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
## 1.4.0 | ||
|
||
* Updated to use Unicode 15.1.0. | ||
|
||
## 1.3.1-wip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't bump to a new version if the previous version has not bee published yet.
Also: does this affect any runtime behavior? if not, no version delta is needed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Do you want to cherry pick the commit that updated the Unicode data? Or should i remove the version changes commits and force push?
I just ran the generate script and not really sure how It will affect runtime behavior but the latest spec introduces new emoji data so could potentially change how you iterate some new emoji characters (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like any library code has changed!
@lrhn – wanna take a look? |
I don't think this update is needed. While Unicode 15.1 introduces new emoji combinations, it does that by assigning a meaning to combinations that can already be made today. It doesn't change how to break the text into grapheme clusters. If there is no difference between Unicode 15.0 and Unicode 15.1 in the grapheme cluster segmentation, it means there is no difference in the generated tables, which is also what we see. That means that there is no functional change, and no need to change anything. |
I see. Feel free to close. |
I ran
tool/generate.dart
to update to the latest Unicode spec 15.1.0.I ran tests and benchmarks OK.
I set the
CHANGELOG.md
andpubspec.yaml
to version 1.4.0