Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Add utilities for different base directories #94

Closed
wants to merge 2 commits into from

Conversation

4e554c4c
Copy link

@4e554c4c 4e554c4c commented Dec 15, 2023

See related dart-lang/sdk#41560, dart-lang/sdk#49166 (comment)

Test plan:

$ dart test
00:01 +16: All tests passed!

run dart doc and inspect docs for correctness.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Copy link

google-cla bot commented Dec 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sortie sortie requested review from kevmoo and removed request for kevmoo March 14, 2024 20:16
@4e554c4c
Copy link
Author

note: the comment by the google bot is out of date. I have signed the CLA

@sortie
Copy link

sortie commented Mar 14, 2024

The contributor pinged me out of band asking for a reviewer, can you route this pull request appropriately @kevmoo?

@kevmoo kevmoo requested a review from devoncarew March 14, 2024 21:23
@kevmoo
Copy link
Contributor

kevmoo commented Mar 14, 2024

@devoncarew ?

@4e554c4c
Copy link
Author

ping :)

@kevmoo
Copy link
Contributor

kevmoo commented Jun 27, 2024

you'll have to rebase this. @devoncarew – thoughts?

@kevmoo kevmoo removed their request for review June 27, 2024 23:03
This should be used to eventually fix dart-lang/sdk#41560.

See dart-lang/sdk#49166 (comment)

Test plan:
```
$ dart test
00:01 +16: All tests passed!
```
run `dart doc` and inspect docs for correctness.
@4e554c4c
Copy link
Author

4e554c4c commented Jun 29, 2024

you'll have to rebase this.

done

@emersion
Copy link

Gentle ping @devoncarew, this would be very nice to have :)

@mosuem
Copy link
Contributor

mosuem commented Oct 29, 2024

Closing as the dart-lang/cli_util repository is merged into the dart-lang/tools monorepo. Please re-open this PR there!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants