This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Add more advice away from predicate #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a best practice entry and expand the dartdoc for `predicate` to mention that the failure messages are not as detailed as `TypeMatcher`, and that the latter is preferred when the value can fail in more than one way. Add a generic argument to the example usage - most cases should prefer to include a generic. Cleanup an unnecessary private `typedef` with a single usage.
jakemac53
approved these changes
Nov 21, 2023
mosuem
pushed a commit
to dart-lang/test
that referenced
this pull request
Oct 17, 2024
Add a best practice entry and expand the dartdoc for `predicate` to mention that the failure messages are not as detailed as `TypeMatcher`, and that the latter is preferred when the value can fail in more than one way. Add a generic argument to the example usage - most cases should prefer to include a generic. Cleanup an unnecessary private `typedef` with a single usage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a best practice entry and expand the dartdoc for
predicatetomention that the failure messages are not as detailed as
TypeMatcher,and that the latter is preferred when the value can fail in more than
one way.
Add a generic argument to the example usage - most cases should prefer
to include a generic.
Cleanup an unnecessary private
typedefwith a single usage.