Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Switch to package:dart_flutter_team_lints #251

Closed
wants to merge 4 commits into from
Closed

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented Jul 10, 2024


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though there aren't meaningful changes, we should update the version to a -wip one indicate there have been changes. The changelog entry can just be empty

analysis_options.yaml Outdated Show resolved Hide resolved
@mosuem
Copy link
Contributor Author

mosuem commented Jul 11, 2024

dart pub get is failing because of package:test, which has a pubspec entry:

 # Use a tight version constraint to ensure that a constraint on matcher
 # properly constrains all features it provides.
 matcher: '>=0.12.16 <0.12.17'

Does this mean we need to upgrade the dependency in test first? And why have this tight upper bound anyhow? Don't we have semver to handle this?

@mosuem mosuem requested a review from jakemac53 July 11, 2024 07:17
@jakemac53
Copy link
Contributor

Does this mean we need to upgrade the dependency in test first?

We should instead just add a dependency_override in this package, on the test package. It might need to list a few of the related packages as well (test_api, test_core).

Does this mean we need to upgrade the dependency in test first? And why have this tight upper bound anyhow? Don't we have semver to handle this?

This is because package:test exports package:matcher.

@mosuem
Copy link
Contributor Author

mosuem commented Oct 18, 2024

Closing as the dart-lang/matcher repository is merged into the dart-lang/test monorepo. Please re-open this PR there!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants