Update tables to Unicode 16.0.0. #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add license file change check. (Since the license file changed this time, and it's something that one should check if it happens.) Some clean-up. Documents that the BG9c rule from Unicode 15.10 is not supported. (That would require more bits of information per character, information that the current table builder does not have, and a correspondingly larger state machine.)
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
| File | Coverage |
|---|---|
| pkgs/characters/lib/src/characters.dart | 💚 100 % |
| pkgs/characters/lib/src/characters_impl.dart | 💚 89 % |
| pkgs/characters/lib/src/grapheme_clusters/table.dart | 💚 100 % |
| pkgs/characters/tool/benchmark.dart | 💔 Not covered |
| pkgs/characters/tool/bin/generate_tables.dart | 💔 Not covered |
| pkgs/characters/tool/bin/generate_tests.dart | 💔 Not covered |
| pkgs/characters/tool/generate.dart | 💔 Not covered |
| pkgs/characters/tool/src/args.dart | 💔 Not covered |
| pkgs/characters/tool/src/data_files.dart | 💔 Not covered |
| pkgs/characters/tool/src/indirect_table.dart | 💔 Not covered |
| pkgs/characters/tool/src/shared.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbols |
|---|
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
devoncarew
reviewed
Oct 18, 2024
Co-authored-by: Devon Carew <[email protected]>
natebosch
approved these changes
Oct 19, 2024
| @@ -19,7 +19,7 @@ import "characters_impl.dart"; | |||
| /// which allows iterating the independent characters in both directions, | |||
| /// but which also provides ways to select other ranges of characters | |||
| /// in different ways. | |||
| abstract class Characters implements Iterable<String> { | |||
| abstract interface class Characters implements Iterable<String> { | |||
There was a problem hiding this comment.
Can we move this to a separate commit? Or if not, please include a note about this change in the commit message. I think we should also include it in the changelog.
There was a problem hiding this comment.
Will revert for now.
It's not like it's useful to extend an empty class, but people do ... things.
The `Characters` class is an empty interface, but adding `interface` to it is potentially breaking, so not doing it as part of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tables to be generated from Unicode 16.0.0.
Addd license file change check. (Since the license file changed this time,
and it's something that one should check if it happens.)
Some clean-up and typo-fixes.
Documents that the BG9c rule from Unicode 15.10 is not supported.
(That would require more bits of information per character, information that the current table
builder does not have, likely doubling this size of the character property table when each character's
category no longer fits in 4 bits, and will require a correspondingly larger state machine with more states times more input character categories.)