Require analyzer ^8.1.1 and migrate off deprecated APIs #4086
Conversation
There was a problem hiding this comment.
Thanks for the migration! I reviewed this all, and it looks great. But I'll let the Pub team approve and land.
Mostly a simple migration. Anything around Annotatable is simplified.
@fshcheglov , I see all of the migrations from "Member" to "Substituted...", and these are all private Impl classes. It would be great it dartdoc did not depend on so much private analyzer impl. While this is perhaps fresh in your mind, can you say perhaps whether you think the dartdoc is unnecessarily reliant on these Substituted classes, or whether it is reasonable, and the Substituted classes should be made part of analyzer's public API?
| @@ -179,6 +179,17 @@ abstract class InheritingContainer extends Container { | |||
| elements.firstWhereOrNull((e) => e is GetterElement); | |||
| final setterElement = | |||
| elements.firstWhereOrNull((e) => e is SetterElement); | |||
|
|
|||
| final isNullOrTopMergeGetter = getterElement == null || | |||
There was a problem hiding this comment.
Thanks for breaking this down into pieces; much easier to understand.
There was a problem hiding this comment.
Yes, I took a look and it was simple to replace members with API classes.
Thank you for the code review.
There was a problem hiding this comment.
Wow... I did not realize all of the Member classes were being used totally unnecessarily :/
|
Sorry for churn in 9965645 and a868964. I accidentally sorted |
|
No worries. Thanks for the cleanup! |
No description provided.