-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug where cupertino_http did not work on iOS<17. #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
package:cupertino_http
Issues related to package:cupertino_http
label
Nov 5, 2024
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
File | Coverage |
---|---|
pkgs/cupertino_http/lib/src/cupertino_api.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/cronet_http/lib/src/jni/jni_bindings.dart |
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart |
pkgs/http/example/main.dart |
pkgs/http2/test/src/flowcontrol/mocks.mocks.dart |
pkgs/http_client_conformance_tests/example/client_test.dart |
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart |
pkgs/http_client_conformance_tests/lib/src/multipart_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/multipart_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/redirect_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/redirect_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/request_body_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/request_body_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/request_headers_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/request_headers_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/request_methods_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/request_methods_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/response_body_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/response_body_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/response_headers_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/response_headers_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/server_errors_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/server_errors_server_web.dart |
pkgs/http_parser/test/example_test.dart |
pkgs/http_profile/lib/http_profile.dart |
pkgs/ok_http/lib/src/jni/bindings.dart |
pkgs/web_socket/example/web_socket_example.dart |
pkgs/web_socket/lib/testing.dart |
pkgs/web_socket_conformance_tests/example/client_test.dart |
pkgs/web_socket_conformance_tests/lib/src/close_local_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/close_local_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/echo_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/echo_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/protocol_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/protocol_server_web.dart |
liamappelbe
approved these changes
Nov 5, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 7, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/4b62792..1156cfe): 1156cfe4 2024-11-06 Jacob MacDonald Use `values` iterator and `update` in map equality/hash (dart-lang/core#718) 9ab5a189 2024-11-05 Jacob MacDonald add a basic benchmark for DeepCollectionEquality (dart-lang/core#717) 9e379158 2024-11-05 Jonas Finnemann Jensen Introduce `IterableMapEntryExtension` for use with `Map.entries`. (dart-lang/core#715) dartdoc (https://github.com/dart-lang/dartdoc/compare/5168f81..24c2a96): 24c2a966 2024-11-04 dependabot[bot] Bump the github-actions group across 1 directory with 4 updates (dart-lang/dartdoc#3922) http (https://github.com/dart-lang/http/compare/8db0d0a..03ced4d): 03ced4d 2024-11-06 Brian Quinlan Upgrade flutter_http_example to cupertino_http (dart-lang/http#1393) df59bac 2024-11-05 Brian Quinlan Release package:cupertino_http 2.0.1 (dart-lang/http#1400) 0544e1f 2024-11-05 Brian Quinlan Fix a bug where cupertino_http did not work on iOS<17. (dart-lang/http#1399) sse (https://github.com/dart-lang/sse/compare/1b02011..befbd6d): befbd6d 2024-11-04 dependabot[bot] Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/sse#118) Change-Id: I2b4ebfe2f56f9478c7e89cd2d3e50485ae44caa0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393943 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]> Auto-Submit: Devon Carew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0.0
incompatible with iOS 15 & 16 #1398dart analyze
error with latest Flutter SDK sdk#57022Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.