Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
HosseinYousefi committed Jan 30, 2025
1 parent ae8585e commit 4dbd7ba
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/ffigen.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ jobs:
run: dart test/setup.dart
- name: Run VM tests
run: dart test
- name: Generate package:jni bindings
run: flutter pub get && dart run tool/generate_ffi_bindings.dart
working-directory: ../jni

# Keep in sync with ffigen_weekly.yaml:test-mac-arm64
test-mac:
Expand All @@ -84,6 +87,9 @@ jobs:
run: dart test/setup.dart
- name: Run VM tests and collect coverage
run: dart run coverage:test_with_coverage --scope-output=ffigen --scope-output=objective_c
- name: Generate package:jni bindings
run: flutter pub get && dart run tool/generate_ffi_bindings.dart
working-directory: ../jni
- name: Upload coverage
uses: coverallsapp/github-action@cfd0633edbd2411b532b808ba7a8b5e04f76d2c8
with:
Expand Down Expand Up @@ -133,6 +139,9 @@ jobs:
run: dart test/setup.dart
- name: Run VM tests
run: dart test
- name: Generate package:jni bindings
run: flutter pub get && dart run tool/generate_ffi_bindings.dart
working-directory: ../jni

# Sanity check the latest `flutter create --template plugin_ffi`.
# This will break if we change the Flutter template or the generated code.
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ffigen_weekly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ jobs:
run: dart test/setup.dart --main-thread-dispatcher
- name: Run VM tests
run: flutter test
- name: Generate package:jni bindings
run: dart run tool/generate_ffi_bindings.dart
working-directory: ../jni
4 changes: 4 additions & 0 deletions pkgs/jni/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,7 @@ flutter:
ffiPlugin: true
package: com.github.dart_lang.jni
pluginClass: JniPlugin

dependency_overrides:
ffigen:
path: ../ffigen

0 comments on commit 4dbd7ba

Please sign in to comment.