Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_cli] Fix system libraries and add documentation - fix test 2 #1890

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

dcharkes
Copy link
Collaborator

If only I knew how to write code for Windows. 🤓

Fixing:

00:00 +0 -1: test\memory_test.dart: executable [E]
  Invalid argument(s): Couldn't resolve native function 'CoTaskMemAlloc' in 'package:system_library/memory_executable.dart' : Failed to lookup symbol 'CoTaskMemAlloc': The specified procedure could not be found.
   (error code: 127).

log

The executable doesn't have access to CoTaskMemAlloc. It's in a win32 library that's loaded into the process. So, only process and system link mode work.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 87.4%. remained the same
when pulling 5d0645e on fix-test-2
into bc1ca8c on main.

@dcharkes dcharkes merged commit f179ec2 into main Jan 14, 2025
32 checks passed
@dcharkes dcharkes deleted the fix-test-2 branch January 14, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants