Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jnigen] Add doc about lifecycle of Java objects #1981

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

HosseinYousefi
Copy link
Member

Closes #1976.

Copy link

github-actions bot commented Feb 11, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

Copy link
Contributor

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, this is very helpful

@HosseinYousefi HosseinYousefi merged commit 5e658f5 into main Feb 12, 2025
27 checks passed
@HosseinYousefi HosseinYousefi deleted the ownership-docs branch February 12, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jnigen] Add docs about lifecycle and ownership
3 participants