Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jni] Migrates java source build of jni from using maven to gradle #2003

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

jwill
Copy link
Contributor

@jwill jwill commented Feb 17, 2025


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Feb 17, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:ffi 2.1.4 ready to publish ffi-v2.1.4
package:ffigen 17.0.0-wip WIP (no publish necessary)
package:jni 0.14.1-wip WIP (no publish necessary)
package:jnigen 0.14.1-wip WIP (no publish necessary)
package:objective_c 6.0.0-wip WIP (no publish necessary)
package:swift2objc 0.0.1-wip WIP (no publish necessary)
package:swiftgen 0.0.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented Feb 17, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
jni None 0.14.0 0.14.1-wip 0.14.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
jni _opaque_pthread_mutex_t
_opaque_pthread_cond_t
_Dart_FinalizableHandle
_ReferenceType

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
jni None 0.14.0 0.14.0 0.14.0 ✔️
Changelog Entry
Package Changed Files
package:jni pkgs/jni/bin/setup.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
jni _opaque_pthread_mutex_t
_opaque_pthread_cond_t
_Dart_FinalizableHandle
_ReferenceType

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@jwill jwill changed the title Migrates java source build of jni from using maven to gradle [jni] Migrates java source build of jni from using maven to gradle Feb 17, 2025
@coveralls
Copy link

coveralls commented Feb 17, 2025

Coverage Status

coverage: 86.952% (-2.9%) from 89.811%
when pulling 87ce790 on jni-gradle
into 23a387d on main.

@jwill jwill requested a review from HosseinYousefi February 17, 2025 05:56
@HosseinYousefi
Copy link
Member

LGTM! Thanks @jwill 🚀

@HosseinYousefi HosseinYousefi merged commit a15e426 into main Feb 18, 2025
27 checks passed
@HosseinYousefi HosseinYousefi deleted the jni-gradle branch February 18, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants