Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffigen] Direct protocol method implementation using blocks #2019

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

liamappelbe
Copy link
Contributor

This is just exposing the internals of method implementation for advanced use cases.

Fixes #1675

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
objective_c Breaking 6.0.0 7.0.0-wip 7.0.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
objective_c _Version

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Feb 20, 2025

Coverage Status

coverage: 87.28% (-0.2%) from 87.433%
when pulling c1b6bcf on proto_direct_impl
into 350488f on main.

@liamappelbe liamappelbe merged commit 301e724 into main Feb 20, 2025
22 checks passed
@liamappelbe liamappelbe deleted the proto_direct_impl branch February 20, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[objective_c] Support protocol method implementation directly using blocks
3 participants