Fix exit-code-threshold help text and reorganize code to match (#1374)

dart-lang · Jun 19, 2024 · 1f5e495 · 1f5e495
1 parent 2658e6b
commit 1f5e495
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -32,7 +32,7 @@ Usage: pana [<options>] --hosted <published package name> [<version>]
 Options:
       --dart-sdk               The directory of the Dart SDK.
       --flutter-sdk            The directory of the Flutter SDK.
-      --exit-code-threshold    The exit code will indicate if (max - granted points) <= threshold.
+      --exit-code-threshold    The exit code will indicate if (max - granted points) > threshold.
   -j, --json                   Output log records and full report as JSON.
       --hosted-url             The server that hosts <package>.
                                (defaults to "https://pub.dev")

diff --git a/bin/pana.dart b/bin/pana.dart
@@ -34,7 +34,7 @@ final _parser = ArgParser()
   )
   ..addOption('exit-code-threshold',
       help:
-          'The exit code will indicate if (max - granted points) <= threshold.')
+          'The exit code will indicate if (max - granted points) > threshold.')
   ..addFlag('json',
       abbr: 'j',
       help: 'Output log records and full report as JSON.',
@@ -266,8 +266,8 @@ Future<void> main(List<String> args) async {
       }
       if (exitCodeThreshold != null &&
           exitCodeThreshold >= 0 &&
-          exitCodeThreshold + summary.report!.grantedPoints <
-              summary.report!.maxPoints) {
+          summary.report!.maxPoints - summary.report!.grantedPoints >
+              exitCodeThreshold) {
         exitCode = 127;
       }
     } catch (e, stack) {

diff --git a/test/goldens/help.txt b/test/goldens/help.txt
@@ -4,7 +4,7 @@ Usage: pana [<options>] --hosted <published package name> [<version>]
 Options:
       --dart-sdk               The directory of the Dart SDK.
       --flutter-sdk            The directory of the Flutter SDK.
-      --exit-code-threshold    The exit code will indicate if (max - granted points) <= threshold.
+      --exit-code-threshold    The exit code will indicate if (max - granted points) > threshold.
   -j, --json                   Output log records and full report as JSON.
       --hosted-url             The server that hosts <package>.
                                (defaults to "https://pub.dev")