Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'flutter pub global activate dartdoc' for Flutter packages. #1428

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Use 'flutter pub global activate dartdoc' for Flutter packages. #1428

merged 1 commit into from
Dec 10, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Dec 9, 2024

No description provided.

@isoos isoos requested a review from sigurdm December 9, 2024 17:34
sigurdm
sigurdm reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed?

sigurdm
sigurdm approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it now - we need to activate and run with the same sdk

@isoos isoos merged commit 0e2e647 into dart-lang:master Dec 10, 2024
5 checks passed
@isoos isoos deleted the use-flutter branch December 10, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @sigurdm