Skip to content

Commit

Permalink
[build/win] Roll crashpad and minichromium deps.
Browse files Browse the repository at this point in the history
Roll not to the lastest, but to the one before move to breaking c++20 changes in those deps.

Pulls changes and fixes to crashpad from 10/22/2018 to 1/10/2024.

TEST=ci

Change-Id: I1ff37eaec91ea6b1fb3d73b38b360b2e8d88a47c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393903
Commit-Queue: Alexander Aprelev <[email protected]>
Reviewed-by: Siva Annamalai <[email protected]>
  • Loading branch information
aam authored and Commit Queue committed Nov 7, 2024
1 parent a31939c commit 073a700
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ vars = {
"yaml_edit_rev": "3d1421b928ec62cf866ec3487940e560852c5c3b",

# Windows deps
"crashpad_rev": "bf327d8ceb6a669607b0dbab5a83a275d03f99ed",
"minichromium_rev": "8d641e30a8b12088649606b912c2bc4947419ccc",
"crashpad_rev": "d256de317164c0eb362bdd9cbb4d259fe6d086f3",
"minichromium_rev": "203a01130fac64bfdcc8cab2e1798c7b2c0619bf",
"googletest_rev": "f854f1d27488996dc8a6db3c9453f80b02585e12",

# Pinned browser versions used by the testing infrastructure. These are not
Expand Down
3 changes: 3 additions & 0 deletions build/config/BUILDCONFIG.gn
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,9 @@ if (is_win) {
set_defaults("shared_library") {
configs = _shared_library_configs
}
set_defaults("loadable_module") {
configs = _shared_library_configs
}

# Source set defaults (also for components in non-component mode).
set_defaults("source_set") {
Expand Down
2 changes: 1 addition & 1 deletion build/config/win/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ config("sdk") {
"_ATL_NO_OPENGL",
"_WINDOWS",
"CERT_CHAIN_PARA_HAS_EXTRA_FIELDS",
"NTDDI_VERSION=0x06030000",
"NTDDI_VERSION=0x0A000006",
"PSAPI_VERSION=1",
"WIN32",
"_SECURE_ATL",
Expand Down

0 comments on commit 073a700

Please sign in to comment.