Skip to content

Commit

Permalink
[cfe] Remove obsolete TODOs
Browse files Browse the repository at this point in the history
Change-Id: I2e0d09850a8aeffdb1816cf81ae5f4595b1cfa02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397780
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
  • Loading branch information
chloestefantsova authored and Commit Queue committed Nov 27, 2024
1 parent f9b0116 commit 18f43cf
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pkg/kernel/lib/type_algebra.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1846,7 +1846,6 @@ class _PrimitiveTypeVerifier implements DartTypeVisitor<bool> {
///
/// Some types are nullable even without the application of the nullable type
/// constructor at the top level, for example, Null or FutureOr<int?>.
// TODO(cstefantsova): Remove [coreTypes] parameter when NullType is landed.
DartType unwrapNullabilityConstructor(DartType type) {
return type.accept(const _NullabilityConstructorUnwrapper());
}
Expand All @@ -1855,8 +1854,6 @@ DartType unwrapNullabilityConstructor(DartType type) {
///
/// Implementing the function as a visitor makes the necessity of supporting a
/// new implementation of [DartType] visible at compile time.
// TODO(cstefantsova): Remove CoreTypes as the second argument when NullType is
// landed.
class _NullabilityConstructorUnwrapper implements DartTypeVisitor<DartType> {
const _NullabilityConstructorUnwrapper();

Expand Down

0 comments on commit 18f43cf

Please sign in to comment.