[CFE] Change error message on package uri error

Bug: #59606
Change-Id: Id2737637f5074bc7ab4a1647fabe64a95a949218
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397760
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Jens Johansen <[email protected]>

pkg/front_end/lib/src/base/uri_translator.dart

@@ -74,7 +74,8 @@ class UriTranslator {
       // https://github.com/dart-lang/package_config/issues/40 is fixed.
       if (reportMessage) {
         options.reportWithoutLocation(
-            templateInvalidPackageUri.withArguments(uri, '$e'), Severity.error);
+            templateInvalidPackageUri.withArguments(uri, "${e.message}"),
+            Severity.error);
       }
       return null;
     }

pkg/front_end/testcases/regress/issue_59606.dart

@@ -0,0 +1,2 @@
+import 'package:foobar1' as a;
+import 'package:foobar%32' as b;

pkg/front_end/testcases/regress/issue_59606.dart.strong.expect

@@ -0,0 +1,25 @@
+//
+// Problems outside component:
+//
+// Error: Invalid package URI 'package:foobar1':
+//   Package URIs must start with the package name followed by a '/'.
+//
+// Error: Invalid package URI 'package:foobar2':
+//   Package URIs must start with the package name followed by a '/'.
+//
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/regress/issue_59606.dart:1:8: Error: Not found: 'package:foobar1'
+// import 'package:foobar1' as a;
+//        ^
+//
+// pkg/front_end/testcases/regress/issue_59606.dart:2:8: Error: Not found: 'package:foobar2'
+// import 'package:foobar%32' as b;
+//        ^
+//
+import self as self;
+
+import "package:foobar1" as a;
+import "package:foobar2" as b;

pkg/front_end/testcases/regress/issue_59606.dart.strong.modular.expect

@@ -0,0 +1,25 @@
+//
+// Problems outside component:
+//
+// Error: Invalid package URI 'package:foobar1':
+//   Package URIs must start with the package name followed by a '/'.
+//
+// Error: Invalid package URI 'package:foobar2':
+//   Package URIs must start with the package name followed by a '/'.
+//
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/regress/issue_59606.dart:1:8: Error: Not found: 'package:foobar1'
+// import 'package:foobar1' as a;
+//        ^
+//
+// pkg/front_end/testcases/regress/issue_59606.dart:2:8: Error: Not found: 'package:foobar2'
+// import 'package:foobar%32' as b;
+//        ^
+//
+import self as self;
+
+import "package:foobar1" as a;
+import "package:foobar2" as b;

pkg/front_end/testcases/regress/issue_59606.dart.strong.outline.expect

@@ -0,0 +1,25 @@
+//
+// Problems outside component:
+//
+// Error: Invalid package URI 'package:foobar1':
+//   Package URIs must start with the package name followed by a '/'.
+//
+// Error: Invalid package URI 'package:foobar2':
+//   Package URIs must start with the package name followed by a '/'.
+//
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/regress/issue_59606.dart:1:8: Error: Not found: 'package:foobar1'
+// import 'package:foobar1' as a;
+//        ^
+//
+// pkg/front_end/testcases/regress/issue_59606.dart:2:8: Error: Not found: 'package:foobar2'
+// import 'package:foobar%32' as b;
+//        ^
+//
+import self as self;
+
+import "package:foobar1" as a;
+import "package:foobar2" as b;

pkg/front_end/testcases/regress/issue_59606.dart.strong.transformed.expect

@@ -0,0 +1,16 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/regress/issue_59606.dart:1:8: Error: Not found: 'package:foobar1'
+// import 'package:foobar1' as a;
+//        ^
+//
+// pkg/front_end/testcases/regress/issue_59606.dart:2:8: Error: Not found: 'package:foobar2'
+// import 'package:foobar%32' as b;
+//        ^
+//
+import self as self;
+
+import "package:foobar1" as a;
+import "package:foobar2" as b;

pkg/front_end/testcases/regress/issue_59606.dart.textual_outline.expect

@@ -0,0 +1,3 @@
+import 'package:foobar1' as a;
+
+import 'package:foobar%32' as b;

pkg/front_end/testcases/regress/issue_59606.dart.textual_outline_modelled.expect

@@ -0,0 +1,2 @@
+import 'package:foobar%32' as b;
+import 'package:foobar1' as a;