Skip to content

Commit

Permalink
Bump args to 09c0fca1785c9df39288a48f767994eed80bed40
Browse files Browse the repository at this point in the history
Changes:
```
> git log --format="%C(auto) %h %s" e623652..09c0fca
 https://dart.googlesource.com/args.git/+/09c0fca Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (286)
 https://dart.googlesource.com/args.git/+/9cdc872 Add argument name when throwing a `ArgParserException`. (283)

```

Diff: https://dart.googlesource.com/args.git/+/e623652744c82533829f2e62b1aba1a6cf06e291..09c0fca1785c9df39288a48f767994eed80bed40/
Change-Id: I804c86db060b3c83acd34c00dd76953c6f28f70a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388744
Reviewed-by: Nate Bosch <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
  • Loading branch information
devoncarew authored and Commit Queue committed Oct 10, 2024
1 parent edecf19 commit d27e144
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 9 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ vars = {
# EOL comment after a dependency to disable this and pin it at its current
# revision.

"args_rev": "e623652744c82533829f2e62b1aba1a6cf06e291", #
"args_rev": "09c0fca1785c9df39288a48f767994eed80bed40", #
"async_rev": "5f70a996f673d625e3502597084653686c3e754c",
"bazel_worker_rev": "aa3cc9e826350b960e0c5a67e6065bcedba8b0ac",
"benchmark_harness_rev": "44f125ae1d045aa3de09fe88a8dd70cb7352d563",
Expand Down
3 changes: 2 additions & 1 deletion pkg/dartdev/test/commands/pub_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ void pub() {
var result = await p.run(['pub', 'deps', '--foo']);
expect(result.exitCode, 64);
expect(result.stdout, isEmpty);
expect(result.stderr, startsWith('Could not find an option named "foo".'));
expect(
result.stderr, startsWith('Could not find an option named "--foo".'));
});
}
4 changes: 2 additions & 2 deletions pkg/dartdev/test/commands/run_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ void main(List<String> args) => print("$b $args");
expect(result.stdout, isEmpty);
expect(
result.stderr,
contains('Could not find an option named "vm-name".'),
contains('Could not find an option named "--vm-name".'),
);
expect(result.exitCode, 64);
});
Expand All @@ -433,7 +433,7 @@ void main(List<String> args) => print("$b $args");
expect(result.stdout, isEmpty);
expect(
result.stderr,
contains('Could not find an option named "verbose_gc".'),
contains('Could not find an option named "--verbose_gc".'),
);
expect(result.exitCode, 64);
});
Expand Down
2 changes: 1 addition & 1 deletion pkg/dev_compiler/test/worker/worker_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ void main() {

expect(result.exitCode, 64);
expect(result.stdout,
contains('Could not find an option named "does-not-exist"'));
contains('Could not find an option named "--does-not-exist"'));
expect(result.stderr, isEmpty);
expect(outputJsFile.existsSync(), isFalse);
});
Expand Down
8 changes: 4 additions & 4 deletions pkg/test_runner/test/options_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,16 @@ void testValidation() {
['--timeout=1,2'], 'Integer value expected for option "--timeout".');

expectValidationError(['--progress=unknown'],
'"unknown" is not an allowed value for option "progress".');
'"unknown" is not an allowed value for option "--progress".');
// Don't allow multiple.
expectValidationError(['--progress=compact,silent'],
'"compact,silent" is not an allowed value for option "progress".');
'"compact,silent" is not an allowed value for option "--progress".');

expectValidationError(['--nnbd=unknown'],
'"unknown" is not an allowed value for option "nnbd".');
'"unknown" is not an allowed value for option "--nnbd".');
// Don't allow multiple.
expectValidationError(['--nnbd=weak,strong'],
'"weak,strong" is not an allowed value for option "nnbd".');
'"weak,strong" is not an allowed value for option "--nnbd".');

// Don't allow invalid named configurations.
expectValidationError(['-ninvalid-vm-android-simarm'],
Expand Down

0 comments on commit d27e144

Please sign in to comment.