Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New assist to add/edit hide at import for ambiguous import #56762

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

New assist to add/edit hide at import for ambiguous import #56762

wants to merge 20 commits into from
+973 −15

Conversation

FMorschel
Copy link
Contributor

@FMorschel FMorschel commented Sep 20, 2024 •
edited
Loading

This PR adds a new assist to add/update hide to imports when ambiguous_import is triggered.

Related to #56830.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

@copybara-service Copybara-Service
Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/386020

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@FMorschel
Copy link
Contributor Author

Requested @bwilkerson to review on Gerrit, as he wrote the options list to fix ambiguous_import.

@FMorschel FMorschel mentioned this pull request Sep 20, 2024
Open
@lrhn lrhn requested review from srawlins and bwilkerson and removed request for srawlins September 25, 2024 19:41
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

3 similar comments
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@FMorschel FMorschel mentioned this pull request Oct 10, 2024
Open
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

4 similar comments
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

5 similar comments
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

2 similar comments
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@FMorschel
sorting file
11eed02
@FMorschel
refactor to simplify user choice and automation
56ae18f 
- Removed verbose process for user.
- Refactored to allow user to specify desired elements explicitly.
- The fix now automatically hide everything else
@FMorschel
readding the ambiguous import fix
67f93bb
@FMorschel
better handling of different prefixes same imported library
dddd163
@FMorschel
makes two fixes - considers discussion
d899f28
@FMorschel
migrates to new element model and fixes tests
10285ac
@FMorschel
new assist to add/edit hide at import for ambiguous import
a6b4f03
@FMorschel
sorting file
0386796
@FMorschel
refactor to simplify user choice and automation
bcd5d7f 
- Removed verbose process for user.
- Refactored to allow user to specify desired elements explicitly.
- The fix now automatically hide everything else
@FMorschel
readding the ambiguous import fix
34fdb5d
@FMorschel
better handling of different prefixes same imported library
35adb2c
@FMorschel
makes two fixes - considers discussion
2cbb312
@FMorschel
refactors - review
1ab3585
@FMorschel
sorts test file
06dac3f
@FMorschel
refactors to simplify the producers calculation - review
06e1823
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service Copybara-Service
Copy link

https://dart-review.googlesource.com/c/sdk/+/386020 has been updated with the latest commits from this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson Awaiting requested review from bwilkerson

Assignees

@srawlins srawlins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FMorschel @srawlins