Document 'dart pub add' support for adding dependency overrides #4726
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Please sign the CLA. We can't review this PR until you've signed the CLA. |
Signed CLA, just now. |
shaikahmadnawaz
requested review from
domesticmouse
and removed request for
parlough
|
Hey @shaikahmadnawaz, thanks so much for working on this! Looks to be a great start. I don't have a chance to review this today, but I plan to get to it tomorrow. Sorry about the delay! |
Thank you for letting me know, I'm waiting for your feedback 😊 |
There was a problem hiding this comment.
Thanks for the pull request @shaikahmadnawaz and for your patience!
It looks pretty good overall, just needs some modification and cleanup to align with our standards and best practices. Also some cross-links to elsewhere to provide some extra context and reduce duplication.
I left suggestions and context for the suggestions. If you're happy with the suggestions, you can commit them directly from the GitHub UI. Feel free to make other changes or comment on my replies for more discussion. And always feel free to ask questions.
Thanks again!
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Thank you for your feedback and suggestions! I have reviewed your comments and made the necessary updates to align with your standards and best practices. Please let me know if there's anything else I can do to improve this PR. |
There was a problem hiding this comment.
Thanks for the pull request @shaikahmadnawaz and making those adjustments, looks good to me!
Thank you so much @parlough for your positive feedback and for taking the time to review my pull request. I'm really glad to hear that the changes I made look good to you! This is my first contribution to this repository, and I'm thrilled to have been able to make a meaningful contribution. Your encouragement means a lot to me, and I look forward to contributing more in the future. |
Hey there! I've created a PR that adds documentation for the new functionality of dart pub add to add dependency overrides. The documentation is now available on the v3.0 branch. Please take a look and let me know if you have any feedback or suggestions. Thank you!