Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from deprecated Sass @import to @use and @forward #4974

Merged
merged 10 commits into from
Jun 26, 2023

Conversation

parlough
Copy link
Member

@parlough parlough commented Jun 9, 2023

@import is being deprecated in favor of @use in Dart Sass (which we are now using). Read more within Sass's @import documentation.

Contributes to #4164 since it will make that migration easier, with all bootstrap usages namespaced. Also enables better code analysis and auto-completion in IDEs.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Visit the preview URL for this PR (updated for commit ac77147):

https://dart-dev--pr4974-migrate-scss-import-y9m0yyb7.web.app

(expires Sun, 02 Jul 2023 23:24:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

@parlough parlough changed the title Migrate from deprecated Sass @import to @use [WIP] Migrate from deprecated Sass @import to @use Jun 9, 2023
@parlough parlough added the review.tech Awaiting Technical Review label Jun 9, 2023
@parlough parlough changed the title [WIP] Migrate from deprecated Sass @import to @use [WIP] Migrate from deprecated Sass @import to @use and @forward Jun 10, 2023
@parlough parlough changed the title [WIP] Migrate from deprecated Sass @import to @use and @forward Migrate from deprecated Sass @import to @use and @forward Jun 10, 2023
@parlough parlough marked this pull request as ready for review June 10, 2023 19:42
@parlough parlough requested a review from johnpryan June 12, 2023 16:26
@johnpryan johnpryan merged commit 7fa3c94 into main Jun 26, 2023
@parlough parlough deleted the migrate/scss-import-to-use branch June 26, 2023 18:14
rmacnak-google pushed a commit to rmacnak-google/site-www that referenced this pull request Sep 5, 2023
…-lang#4974)

`@import` is being deprecated in favor of `@use` in Dart Sass (which we
are now using). Read more within Sass's [`@import`
documentation](https://sass-lang.com/documentation/at-rules/import).

Contributes to dart-lang#4164 since
it will make that migration easier, with all bootstrap usages
namespaced. Also enables better code analysis and auto-completion in
IDEs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review.tech Awaiting Technical Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants