Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newInstanceNamed with empty name #1194

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/code_builder/lib/src/specs/expression.dart
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ abstract mixin class ExpressionEmitter
final out = output ??= StringBuffer();
return _writeConstExpression(out, expression.isConst, () {
expression.target.accept(this, out);
if (expression.name != null) {
if (expression.name case final name? when name.isNotEmpty) {
out
..write('.')
..write(expression.name);
Expand Down
7 changes: 7 additions & 0 deletions pkgs/code_builder/test/specs/code/expression_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,13 @@ void main() {
);
});

test('should emit invoking unnamed constructor when name is empty', () {
expect(
refer('Foo').newInstanceNamed('', []),
equalsDart('Foo()'),
);
});

test('should emit invoking const Type()', () {
expect(
refer('Object').constInstance([]),
Expand Down