Skip to content

Add Support for Configuration of Dart JS Interop Gen #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 7, 2025

Conversation

nikeokoronkwo
Copy link
Contributor

@nikeokoronkwo nikeokoronkwo commented Jun 11, 2025

Fixes #376

This issue adds basic support for configuration for the dart js interop generator. Configuration will be extended over time as support for different typescript declarations are added to the project.

@nikeokoronkwo nikeokoronkwo marked this pull request as ready for review June 19, 2025 03:06
@kevmoo
Copy link
Member

kevmoo commented Jun 26, 2025

note you need to rebase here!

Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Licenses on all new files :)

Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srujzs srujzs merged commit fb8a149 into dart-lang:main Jul 7, 2025
16 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 8, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/64dfa7f..9b007b3):
  9b007b3  2025-07-07  Jacob MacDonald  Add failure reasons to tool call analytics events (dart-lang/ai#219)
  c8dc5da  2025-07-07  Jacob MacDonald  don't bail early when running in multiple roots (dart-lang/ai#218)
  2541b6c  2025-07-02  Kenzie Davisson  Remove VS Code mcp instructions in favor of Dart-Code setting. (dart-lang/ai#206)
  70daa1f  2025-07-02  Jacob MacDonald  release dart_mcp 0.3.0 (dart-lang/ai#216)
  a252a46  2025-07-01  Jacob MacDonald  add retry logic to try and make dtd_test less flaky (dart-lang/ai#214)
  9e0b973  2025-07-01  Jacob MacDonald  add a test that the arg parser library only depends on package:args (dart-lang/ai#213)

http (https://github.com/dart-lang/http/compare/e70a41b..7d2d87e):
  7d2d87e  2025-07-02  Brian Quinlan  Fix `Connection reset by peer` in protocol error tests (dart-lang/http#1786)

i18n (https://github.com/dart-lang/i18n/compare/ab90327..42c4932):
  42c49328  2025-07-07  Googler  No public description
  87fd0156  2025-07-07  Michael Goderbauer  [intl4x] Re-enable Windows (dart-lang/i18n#986)
  912a7720  2025-07-07  Copybara-Service  Merge pull request `#985` from dart-lang:fixConstantEvaluator
  52f5beeb  2025-07-07  Moritz  Small cleanups in intl4x (dart-lang/i18n#988)
  6e8ef245  2025-07-07  Moritz  squash

sync_http (https://github.com/dart-lang/sync_http/compare/dc54465..c07f96f):
  c07f96f  2025-07-03  Kevin Moore  Update to latest lints, required Dart 3.7 (google/sync_http.dart#55)

tools (https://github.com/dart-lang/tools/compare/7bf22c9..6282b35):
  6282b35e  2025-07-03  Lasse R.H. Nielsen  [Markdown] Fix HTML comment parser. (dart-lang/tools#2121)

web (https://github.com/dart-lang/web/compare/3e11172..fb8a149):
  fb8a149  2025-07-07  Nikechukwu  Add Support for Configuration of Dart JS Interop Gen (dart-lang/web#386)

Change-Id: Ib243021ed77846a8451f60fa320e5cf40e85aa27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/439320
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web_generator] Configuration Support
3 participants