-
Notifications
You must be signed in to change notification settings - Fork 34
[interop] Adding support for dart:js_interop
and package:web
types
#403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nikeokoronkwo
wants to merge
9
commits into
dart-lang:main
Choose a base branch
from
nikeokoronkwo:interop/dart-js-interop-primitives
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[interop] Adding support for dart:js_interop
and package:web
types
#403
nikeokoronkwo
wants to merge
9
commits into
dart-lang:main
from
nikeokoronkwo:interop/dart-js-interop-primitives
+292
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujzs
reviewed
Jul 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's add license to all the new files as well.
…pe.referred` for supported types in `dart:js_interop`
You'll need to do some rebasing @nikeokoronkwo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #381
This PR completes support for builtin types for the Dart JS Interop Generator Tool by adding support for types natively available to TypeScript and JavaScript, where possible.
This includes
dart:js_interop
types for JS Interoperable typespackage:web
where possible for JS Interoperable types that are web/dom lib types and present inpackage:web