Updated Helpers.cs tryReadFile method so that it handles exceptions that may happen, without crashing the program.

dotnet/DWXConnect/api/Helpers.cs

@@ -65,27 +65,69 @@ public static void tryDeleteFile(string path)
         }
 
 
-		/*Formats a double value to string. 
-		
-		Args:
-			value (double): numeric value to format.
-		
-		*/
-		public static string format(double value)
+	/*Formats a double value to string. 
+
+	Args:
+		value (double): numeric value to format.
+
+	*/
+	public static string format(double value)
         {
             return value.ToString("G", CultureInfo.CreateSpecificCulture("en-US"));
         }
 
-        public static string tryReadFile(string path)
-        {
-            try
-            {
-                return File.ReadAllText(path);
-            }
-            catch
-            {
-                return "";
-            }
-        }
+	/*Tries to read a file and handles various exceptions which then return an empty string and writes the exception to the console.
+
+ 	*/
+	public static string tryReadFile(string path)
+    	{
+		var fileName = GetFileNameFromPath(path);
+
+	        try
+	        {
+	            return File.ReadAllText(path);
+	        }
+	        catch (DirectoryNotFoundException)
+	        {
+	            Console.WriteLine($"api.Helpers.tryReadFile | {fileName} | DirectoryNotFoundException. Returning empty string.");
+	            return "";
+	        }
+	        catch (FileNotFoundException)
+	        {
+	            Console.WriteLine($"api.Helpers.tryReadFile | {fileName} | FileNotFoundException. Creating empty file at path ({path}) & returning empty string.");
+	            CreateEmptyFile(path);
+	            return "";
+	        }
+	        catch (IOException)
+	        {
+	            Console.WriteLine($"api.Helpers.tryReadFile | {fileName} | IOException. Race condition. Most likely this process and the MetaTrader EA both trying to access/use the file simultaneously. Returning empty string.");
+	            return "";
+	        }
+    	}
+
+	private static void CreateEmptyFile(string filePath)
+    	{
+		File.Create(filePath).Dispose();
+    	}
+
+	private static string GetFileNameFromPath(string path)
+    	{
+	        try
+	        {
+	            return path.Split("\\").Last();
+	        }
+	        catch (Exception)
+	        {
+	            try
+	            {
+	                return path.Split("/").Last();
+	            }
+	            catch (Exception e)
+	            {
+	                Console.WriteLine(e);
+	                throw;
+	            }
+	        }
+    	}
     }
 }