Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTON Staking Part.1 #1409

Merged
merged 19 commits into from
Feb 23, 2024
Merged

KTON Staking Part.1 #1409

merged 19 commits into from
Feb 23, 2024

Conversation

AurevoirXavier
Copy link
Member

@AurevoirXavier AurevoirXavier commented Feb 21, 2024

Part of #1395.

@AurevoirXavier AurevoirXavier added the C-Pallet [Component] Something about pallet label Feb 21, 2024
@AurevoirXavier
Copy link
Member Author

Please help fix the precompile test. @boundless-forest

@boundless-forest
Copy link
Member

Please help fix the precompile test. @boundless-forest

I didn't have a deep understanding of the current KTON design, so just fix the precompile tests according to your code changes. It seems that only one interface has been updated.

@AurevoirXavier AurevoirXavier added the S-Audited [Security] Audited label Feb 22, 2024
@hackfisher
Copy link
Contributor

@AurevoirXavier Still some issues with CI.

pallet/staking/src/lib.rs Outdated Show resolved Hide resolved
pallet/staking/src/lib.rs Outdated Show resolved Hide resolved
pallet/staking/src/lib.rs Outdated Show resolved Hide resolved
precompile/staking/src/lib.rs Show resolved Hide resolved
pallet/staking/src/lib.rs Outdated Show resolved Hide resolved
Copy link

Check f6f954c crab-dev

Check runtime version

Check runtime storage

Pallet DarwiniaStaking
+ Entry: StorageEntryMetadata { name: "MigrationStartBlock", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: [" Migration starting block."] }

Copy link

Check f6f954c pangolin-dev

Check runtime version

Check runtime storage

Pallet DarwiniaStaking
+ Entry: StorageEntryMetadata { name: "MigrationStartBlock", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: [" Migration starting block."] }

Copy link

Check f6f954c pangoro-dev

Check runtime version

Check runtime storage

Copy link

Check f6f954c darwinia-dev

Check runtime version

Check runtime storage

Pallet DarwiniaStaking
+ Entry: StorageEntryMetadata { name: "MigrationStartBlock", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: [" Migration starting block."] }

Copy link
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test it on Pangolin

Copy link
Member

@boundless-forest boundless-forest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Congrats!

@AurevoirXavier AurevoirXavier added this pull request to the merge queue Feb 23, 2024
Copy link
Contributor

@hujw77 hujw77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boundless-forest boundless-forest removed this pull request from the merge queue due to a manual request Feb 23, 2024
@boundless-forest boundless-forest added this pull request to the merge queue Feb 23, 2024
@hackfisher hackfisher removed this pull request from the merge queue due to a manual request Feb 23, 2024
@hackfisher hackfisher added this pull request to the merge queue Feb 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 23, 2024
@AurevoirXavier AurevoirXavier merged commit 64ee376 into main Feb 23, 2024
12 checks passed
@AurevoirXavier AurevoirXavier deleted the xavier/kton-staking- branch February 23, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Pallet [Component] Something about pallet S-Audited [Security] Audited
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants