Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add LegalInfo (authorship, copyright holder, license) to FileValue (DEV-4502) #3459

Merged
merged 73 commits into from
Feb 18, 2025
Merged

feat: Add LegalInfo (authorship, copyright holder, license) to FileValue (DEV-4502) #3459

merged 73 commits into from
Feb 18, 2025

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Jan 15, 2025 •
edited
Loading

Description

  • Move Copyright and Licenses relevant models out of the KnoraProject
  • Add Authorship value class
  • Add copyright holder
  • Add License
  • Allow to provide legal info to FileValues, i.e. assets
  • update knora-base ontology and version

@seakayone seakayone changed the title feat/add copyright holder and authorship to filevalue feat: Add copyright holder and authorship to filevalue Jan 15, 2025
@seakayone seakayone force-pushed the feat/add-copyright-holder-and-authorship-to-filevalue branch from 12c0732 to 180400c Compare February 13, 2025 11:52
@seakayone seakayone force-pushed the feat/add-copyright-holder-and-authorship-to-filevalue branch from 180400c to 56fc36b Compare February 13, 2025 11:54
@seakayone seakayone changed the title feat: Add copyright holder and authorship to filevalue feat: Add license to FileValue Feb 13, 2025
@seakayone seakayone changed the title feat: Add license to FileValue feat: Add LegalInfo (authorship, copyright holder, license) to FileValue Feb 13, 2025
@seakayone seakayone force-pushed the feat/add-copyright-holder-and-authorship-to-filevalue branch from 359ba38 to 13f9a0f Compare February 13, 2025 14:51
@seakayone seakayone marked this pull request as ready for review February 14, 2025 14:29
siers
siers approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a closer look at LegalInfoE2ESpec, it looks about right. 👍

BalduinLandolt
BalduinLandolt approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to review this late! Looks good to me

@seakayone seakayone merged commit 74b42b3 into main Feb 18, 2025
10 checks passed
@seakayone seakayone deleted the feat/add-copyright-holder-and-authorship-to-filevalue branch February 18, 2025 14:22
@daschbot daschbot mentioned this pull request Feb 18, 2025
Merged
@seakayone seakayone changed the title feat: Add LegalInfo (authorship, copyright holder, license) to FileValue feat: Add LegalInfo (authorship, copyright holder, license) to FileValue (DEV-4502) Feb 20, 2025
@linear Linear
Copy link

linear bot commented Feb 20, 2025

DEV-4502 Add LegalInfo to v2 and admin api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siers siers siers approved these changes

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@mpro7 mpro7 Awaiting requested review from mpro7 mpro7 is a code owner

Assignees

@seakayone seakayone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @siers @BalduinLandolt