feat: add footnotes functionnality to richtext #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libs/vre/resource-editor/resource-properties/src/lib/property-row.component.ts # package-lock.json
…ssues # Conflicts: # package-lock.json
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../resource-editor/resource-properties/src/lib/switch-components/rich-text-switch.component.ts
Fixed
Show fixed
Hide fixed
irmastnt
requested changes
Jan 30, 2025
| if (targetElement.nodeName.toLowerCase() === 'footnote') { | ||
| const content = targetElement.getAttribute('content'); | ||
| if (content === null) { | ||
| throw new AppError('Footnote content is null'); |
There was a problem hiding this comment.
intended for the dev
libs/vre/resource-editor/resource-properties/src/lib/footnotes.component.ts
Outdated
Show resolved
Hide resolved
libs/vre/resource-editor/resource-properties/src/lib/footnotes.component.ts
Outdated
Show resolved
Hide resolved
| @@ -22,6 +23,51 @@ describe('Resource', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('footnotes', () => { | |||
There was a problem hiding this comment.
there might be more tests with footnotes, I suggest moving them to a separate test file
libs/vre/resource-editor/resource-properties/src/lib/footnotes.component.ts
Outdated
Show resolved
Hide resolved
mpro7
reviewed
Jan 30, 2025
libs/vre/resource-editor/resource-properties/src/lib/footnote.directive.ts
Show resolved
Hide resolved
libs/vre/resource-editor/resource-properties/src/lib/footnote.directive.ts
Outdated
Show resolved
Hide resolved
libs/vre/resource-editor/resource-properties/src/lib/footnote.service.ts
Outdated
Show resolved
Hide resolved
libs/vre/resource-editor/resource-properties/src/lib/property-row.component.ts
Outdated
Show resolved
Hide resolved
.../resource-editor/resource-properties/src/lib/switch-components/rich-text-switch.component.ts
Show resolved
Hide resolved
libs/vre/resource-editor/resource-properties/src/lib/property-row.component.ts
Outdated
Show resolved
Hide resolved
libs/vre/resource-editor/resource-properties/src/lib/footnote.directive.ts
Outdated
Show resolved
Hide resolved
irmastnt
approved these changes
Jan 31, 2025
This reverts commit 52b6a7d.
mpro7
approved these changes
Jan 31, 2025
.../resource-editor/resource-properties/src/lib/switch-components/rich-text-switch.component.ts
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.