-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to dash::Future #451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes look good so far, however I have some concerns regarding the performance of multiple relatively small async copy calls. Are there already benchmark results comparing before and after? If not, we could easily use the DASH implementation of Cafbench therefor.
I don't think we have a proper benchmark for it but it would be easy to create one. I might give it a try next week. However, I don't immediately see how we could improve performance without sacrificing features. The current implementation of I am open to ideas on how to save the dynamic allocation of the |
Did not have a look at the implementation yet but the PR is a good catch. |
…nto feat-dart-handlefree
…tion if necessary
@fuchsto Good point. Did that, made me change the implementation even more:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good and IMO we can merge it. As the implementation of copy will change anyways I have no problem with using handles there. In the future we can improve that by providing optimized copy for tiny transfers.
The changes related to dash::Future
are really good ones.
This PR extends
dash::Future
to allow for a meaningfultest()
function and proper tear-down. The latter is required to avoid memory leaks ifdash::copy_async
uses handles and the user does notwait()
on it.Fixes #416
See also #447