Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat halo #717

Merged
merged 76 commits into from
Feb 1, 2021
Merged

Feat halo #717

merged 76 commits into from
Feb 1, 2021

Conversation

dhinf
Copy link
Member

@dhinf dhinf commented Feb 1, 2021 •
edited
Loading

  • Refactored the inner data structure to set up the boundary and halo environment. Removed code redundancy and improved maintainability.
  • Now very small blocks work fine.
  • Added coordinate based access for inner and boundary elements.
    Issue Directly specify the halo width #680

dhinf and others added 30 commits June 5, 2019 11:02
@dhinf
name change in RegionCoords: MaxIndex is NumRegionsMax now
114ade3
@dhinf
fixed update function of inner stencil operator for 2D specialization…
56882fe 
…; added update function for blocking
@dhinf
enables assignment operator for StencilIterator
1fec0d7
@dhinf
removed reference when returning coords
5609247
@dhinf
fixed update in inner stencil operator
de705d2
@dhinf
added boundary region dependency check for bordering halo regions
142a78a
@dhinf
now region border indicator uses a boolean for pre and post center area
a0183d5
@dhinf
added mapped boundary regions to support region wise boundary iterator
fdd47a1
@dhinf
Now halos are packed and transfered.
6bf2531
@dhinf
Merge branch 'development' of https://github.com/dash-project/dash in…
812a547 
…to feat-halo
@dhinf
fixed RegionIterator operator* and method dart_gptr(); some fixes pac…
9c01036 
…ked transfer
@dhinf
fixed region Region output, added signal for non packed but used halo…
b59a826 
… regions
@dhinf
added missing regions to _signal_handles
289004e
@dhinf
replaced volatile based busy waiting with dart_get and minor code opt…
8a847a3 
…imizations
@dhinf
fixed move constructor and move and copy assignment operator
fe46973
@dhinf
replaced RegionIter with GlobViewIter -> reduced code redundancy
e83a085
@dhinf
optimized inner and outer stencil iterator
f8c2e47
@dhinf
fixed bugs
bd88aff
@dhinf
Merge branch 'development' of https://github.com/dash-project/dash in…
42eece3 
…to feat-halo
@dhinf
fixed merge conflicts
e2a13b2
@dhinf
fixed errors for different extents between local views
3979a3e
@dhinf
added missing include
72a6ea7
@dhinf
started to clean up code and fix warnings
735fda0
@devreal
Allocated dynamic memory at page boundaries
74d0a16
@dhinf
merge memalign
6080d7d
@dhinf
added new coordinate based access for the halo wrapper
6e932b2
@dhinf
addef factory for stencil specs, for now only full stencil can be cre…
cfd02ef 
…ated. minor bug fixes
@dhinf
fixed constructors
1f31220
@dhinf
fixed wrong region_number in HaloSpec
0cb993b
@dhinf
fix: region wise update (blocking and async)
c6521de
dhinf and others added 25 commits June 9, 2020 13:57
@dhinf
fixed errors for different extents between local views
9b0074e
@dhinf
added missing include
688ed2c
@dhinf
started to clean up code and fix warnings
0078535
@devreal @dhinf
Allocated dynamic memory at page boundaries
ef9abb6
@dhinf
added new coordinate based access for the halo wrapper
ecf5b6b
@dhinf
addef factory for stencil specs, for now only full stencil can be cre…
8606b04 
…ated. minor bug fixes
@dhinf
fixed constructors
5f7c907
@dhinf
fixed wrong region_number in HaloSpec
7f199ce
@dhinf
fix: region wise update (blocking and async)
e34d000
@dhinf
first step of restructering
ddc4d3f
@dhinf
fixed alias for stencil point value
d3544ef
@dhinf
Merge branch 'feat-halo' of https://github.com/dash-project/dash into…
1653727 
… feat-halo
@dhinf
Merge branch 'development' into feat-halo
6e38c7a
@dhinf
removed the slow vs fast solution, because iterators are fast too now
b24c540
@dhinf
removed HaloWrapper friendship in matrix
e70de57
@dhinf
fixes teamspec neighbor bug and adds array based argument to neighbor…
ac99756 
… functions
@dhinf
refactored and fixed signal and packing environment
d5e1204
@dhinf
restructured halo and boundary environment
0fb4dc5
@dhinf
fixed glob_bound ref in halo_block, unused code fragments
128a8e5
@dhinf
Updated config.yml
d7733a6
@dhinf
fixed outdated extention access
d281d99
@dhinf
Merge branch 'development' of https://github.com/dash-project/dash in…
4a5a33d 
…to feat-halo
@dhinf
minor name changes, inner and inner+boundary view check to small bloc…
cb417dc 
…k extent
@dhinf
adapted to new name changes in Halo.h
7e78d0a
@dhinf
Merge branch 'feat-halo' of https://github.com/dash-project/dash into…
8cd2137 
… feat-halo
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #717 (8cd2137) into development (e1af056) will increase coverage by 0.16%.
The diff coverage is 97.25%.

@@               Coverage Diff               @@
##           development     #717      +/-   ##
===============================================
+ Coverage        85.24%   85.41%   +0.16%     
===============================================
  Files              336      340       +4     
  Lines            25043    25479     +436     
  Branches         11759    12059     +300     
===============================================
+ Hits             21349    21764     +415     
- Misses            3693     3714      +21     
  Partials             1        1
Impacted Files Coverage Δ
dash/include/dash/Dimensional.h 81.08% <ø> (+0.34%) ⬆️
dash/include/dash/Matrix.h 100.00% <ø> (ø)
dash/include/dash/iterator/GlobViewIter.h 81.14% <ø> (+0.44%) ⬆️
dash/include/dash/halo/Types.h 30.00% <30.00%> (ø)
dash/include/dash/TeamSpec.h 87.50% <94.11%> (+1.18%) ⬆️
dash/include/dash/halo/Halo.h 95.77% <95.07%> (-1.84%) ⬇️
dash/include/dash/halo/Stencil.h 97.43% <97.43%> (ø)
dash/include/dash/halo/Region.h 97.63% <97.63%> (ø)
dash/include/dash/halo/iterator/StencilIterator.h 98.21% <98.59%> (-0.46%) ⬇️
dash/include/dash/halo/HaloMemory.h 99.54% <99.54%> (ø)
... and 16 more

@dhinf dhinf requested a review from bertwesarg February 1, 2021 00:18
bertwesarg
bertwesarg approved these changes Feb 1, 2021
View reviewed changes
.circleci/config.yml
@@ -13,7 +13,7 @@ jobs:
steps:
- checkout
- run: bash dash/scripts/dash-ci.sh Release
- run: bash -c 'export DART_FORCE_C_STD=99; dash/scripts/dash-ci.sh Minimal'
#- run: bash -c 'export DART_FORCE_C_STD=99; dash/scripts/dash-ci.sh Minimal'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed?

@dhinf dhinf merged commit c561931 into development Feb 1, 2021
@dhinf dhinf deleted the feat-halo branch February 1, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertwesarg bertwesarg bertwesarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhinf @bertwesarg @devreal