Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ws.waitForVout & clear ping timeout #19

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

jojobyte
Copy link
Contributor

Fix browser bug with missing waitForVout and setTimeout not being cleared.

It happens at this point in my stream https://youtu.be/Hik0sLqudYg?t=3108 for waitForVout & https://youtu.be/Hik0sLqudYg?t=3805 for the setTimeout issue, after fixing #17

@jojobyte jojobyte added the bug Something isn't working label Jan 24, 2023
Copy link
Member

@coolaj86 coolaj86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jojobyte jojobyte force-pushed the fix/waitForVout-ping-timeout branch from 81fb94b to cead9e8 Compare January 24, 2023 03:39
@jojobyte jojobyte merged commit 6862bfa into dashhive:fix-v18 Jan 24, 2023
@jojobyte jojobyte self-assigned this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants