Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace @root/request with fetch #20

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Replace @root/request with fetch #20

merged 2 commits into from
Jan 24, 2023

Conversation

jojobyte
Copy link
Contributor

This removes the dependency on @root/request module and switches to fetch

Supersedes #17

@jojobyte jojobyte added the enhancement New feature or request label Jan 24, 2023
@jojobyte jojobyte force-pushed the feat/replace-request-with-fetch branch from 3f06f6f to aa60a06 Compare January 24, 2023 08:15
@jojobyte jojobyte mentioned this pull request Jan 24, 2023
Closed
@jojobyte jojobyte requested a review from coolaj86 January 24, 2023 08:17
@jojobyte jojobyte self-assigned this Jan 24, 2023
coolaj86
coolaj86 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@coolaj86 coolaj86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jojobyte jojobyte force-pushed the feat/replace-request-with-fetch branch from aa60a06 to 6fbfacc Compare January 24, 2023 08:45
@coolaj86 coolaj86 merged commit 6fbfacc into fix-v18 Jan 24, 2023
@coolaj86 coolaj86 deleted the feat/replace-request-with-fetch branch March 17, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolaj86 coolaj86 coolaj86 approved these changes

Assignees

@jojobyte jojobyte

Labels
enhancement New feature or request
Projects
Crowd Node (SDK, CLI)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jojobyte @coolaj86