ref: externalize storage from legacy tx functions #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolaj86
force-pushed
the
ref-ext-storage
branch
9 times, most recently
from
07b3f66 to
f292dc0
Compare
coolaj86
changed the title
coolaj86
force-pushed
the
ref-ext-storage
branch
from
f292dc0 to
bcc6328
Compare
…nalizeAndSignTx(txDraft, keys)
coolaj86
force-pushed
the
ref-ext-storage
branch
from
bcc6328 to
6e7713e
Compare
coolaj86
force-pushed
the
ref-ext-storage
branch
from
6e7713e to
62879f9
Compare
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/[email protected] |
coolaj86
force-pushed
the
ref-ext-storage
branch
from
62879f9 to
0821690
Compare
coolaj86
force-pushed
the
ref-ext-storage
branch
from
023c5cc to
a40de32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using more of the wallet SDK functionality without being dependent on its caching strategy.
Although this results in functions that should probably move to DashTx before v1.0 of DashWallet - it's okay, we're still figuring things out.