-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with upstream #1
base: main
Are you sure you want to change the base?
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@noble/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
Since this is a major version change and major breaking change, and it's tracking a different repo, I think it makes more sense to save the current I think I can do that... |
d587c1a
to
88c4dfc
Compare
@coolaj86 That is more or less what this is doing just with tweaks to |
…nto sync-with-upstream
88c4dfc
to
6301cc6
Compare
@jojobyte Do we still need to maintain a fork with the new version? Or will it work without our modifications now? |
@coolaj86 Do you mean if we're switching to ESM Imports by default and dropping IIFE/require? Not sure, but I can test it if that is what you're asking. We may need to update our repos depending on the fork though to the |
This synchronizes our fork with the upstream version and should update the IIFE version to have the latest changes.
Breaking changes to be aware of:
Secp256k1.utils._normalizePrivateKey
Secp256k1.utils._bigintTo32Bytes
Secp256k1.utils.mod
Secp256k1.Point.BASE.multiplyAndAddUnsafe
Secp256k1.utils.normPrivateKeyToScalar
Secp256k1.etc.numberToBytesBE
Secp256k1.etc.mod
Secp256k1.ProjectivePoint.BASE.mulAddQUns
ProjectivePoint
instead ofPoint
, although I included both in our IIFE wrapper.