Skip to content

Commit

Permalink
docs: 📝 Shift some Todos to Roadmap Backlog
Browse files Browse the repository at this point in the history
  • Loading branch information
jojobyte committed Feb 19, 2024
1 parent 3801ae3 commit 65ee57e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 23 deletions.
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,7 @@ A Graphical User Interface (GUI) for
- [ ] We need to support importing raw xpubs if we don’t already.
- [ ] style: Top button is “adjective noun”, bottom two buttons are “verb noun”. Maybe make it consistent.
- [ ] feat: Every time I click Request the wallet generates a new address. This might be unsettling for users. Need to rethink this functionality. Side note/question: Is this cycling through the 0 index on the HD path when no contact is selected? Either way, we may want to put our own username in the alias input box by default, which would be the default funding mechanism.
- [ ] Contact Data List Selector in the Send Dialog on mobile does not show contact alias hints
- Appears to be an issue specific to Firefox on Android, both normal version (in normal & private view) & Firefox Focus
- [ ] Edit Profile, Add Contact & Insufficient Wallet Funds Dialogs have layout issues on mobile
- [ ]
23 changes: 0 additions & 23 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,32 +13,9 @@

### Bugs
#### Mobile Specific
- [ ] Edit Profile, Add Contact & Insufficient Wallet Funds Dialogs have layout issues on mobile
- [ ] Contact Data List Selector in the Send Dialog on mobile does not show contact alias hints
- Appears to be an issue specific to Firefox on Android, both normal version (in normal & private view) & Firefox Focus
- [x] Copy Buttons don't seem to work reliably
- [x] Unique Alias Collision with only the one contact you're trying to pair with
- Unable to verify and reproduce issue
- [x] After initial pairing between mobile & desktop wallets, we funded the wallet from an external source, no page refresh but websocket updated balance, attempting to send to mobile contact from desktop failed
- Should be fixed by https://github.com/dashhive/wallet-ui/pull/31/commits/6c96982925544aeafac470d46722a2f5bdb050d0
- tried to POST to https://insight.dash.org/insight-api/addrs/utxo with an empty `addrs` array/string
- TypeError: Cannot read properties of undefined (reading 'split')
at AddressController.checkAddrs (/insight/node_modules/@dashevo/insight-api/lib/addresses.js:100:34)
at Layer.handle [as handle_request] (/insight/node_modules/express/lib/router/layer.js:95:5)
at next (/insight/node_modules/express/lib/router/route.js:144:13)
at /insight/node_modules/@dashevo/insight-api/lib/index.js:78:5
at Layer.handle [as handle_request] (/insight/node_modules/express/lib/router/layer.js:95:5)
at next (/insight/node_modules/express/lib/router/route.js:144:13)
at Route.dispatch (/insight/node_modules/express/lib/router/route.js:114:3)
at Layer.handle [as handle_request] (/insight/node_modules/express/lib/router/layer.js:95:5)
at /insight/node_modules/express/lib/router/index.js:284:15
at Function.process_params (/insight/node_modules/express/lib/router/index.js:346:12)
- [ ]

### Enhancements
- [x] Dialog: Sent Funds Confirmation
- currently send closes, and you see your balance change
- we should show a "Funds Sent" type dialog with a link to the Transaction ID
- [ ] Batch Generate tweaks
- need to check each address funds and generate 20 past the last address with funds
- need to pre-generate accounts with some addresses when importing a phrase to start adding contacts after the last account with funds
Expand Down

0 comments on commit 65ee57e

Please sign in to comment.