Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: drop EoL Python 3.7 and 3.8, Go 1.17, replace with Python 3.12, Go 1.22 #103

Merged
merged 2 commits into from
Dec 4, 2024
Merged

ci: drop EoL Python 3.7 and 3.8, Go 1.17, replace with Python 3.12, Go 1.22 #103

merged 2 commits into from
Dec 4, 2024

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Dec 4, 2024 •
edited
Loading

Additional Information

  • GitHub Actions has refused to work with Python 3.7 on macos-latest (14.7), using an arm64 runner (build)
  • Python 3.7 was declared EoL in June 2023 as was 3.8 in October 2024 (source). It has instead been replaced with Python 3.12 (shipped with Ubuntu 24.04 noble, source)
  • Python 3.13 currently doesn't work with bindings (build)
  • Go 1.12 was EoL in Aug 2022 (source), replaced with lowest supported Go version, 1.22

@kwvg kwvg changed the base branch from main to develop December 4, 2024 10:50
@kwvg kwvg changed the title ci: drop EoL Python 3.7 and 3.8, replace with Python 3.12 and 3.13 ci: drop EoL Python 3.7 and 3.8, replace with Python 3.12 Dec 4, 2024
@kwvg kwvg changed the title ci: drop EoL Python 3.7 and 3.8, replace with Python 3.12 ci: drop EoL Python 3.7 and 3.8, Go 1.17, replace with Python 3.12, Go 1.22 Dec 4, 2024
@kwvg kwvg marked this pull request as ready for review December 4, 2024 12:00
UdjinM6
UdjinM6 approved these changes Dec 4, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks happy

utACK 56b2d4a

PastaPastaPasta
PastaPastaPasta approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 56b2d4a

@PastaPastaPasta PastaPastaPasta merged commit aad89e3 into dashpay:develop Dec 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@knst knst Awaiting requested review from knst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwvg @UdjinM6 @PastaPastaPasta