Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dash is no more pretending being a 'libdashbls' #76

Merged
merged 1 commit into from
May 11, 2023
Merged

fix: dash is no more pretending being a 'libdashbls' #76

merged 1 commit into from
May 11, 2023

Conversation

knst
Copy link

@knst knst commented May 10, 2023

It resolves: dashpay/dash#5270

It is still workaround but it should be more reliable.

@knst knst requested review from kwvg and PastaPastaPasta May 10, 2023 12:39
kwvg
kwvg approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@knst
Copy link
Author

knst commented May 10, 2023

seems as CI broken: this PR has same broken tests: #75

@kwvg
Copy link
Collaborator

kwvg commented May 10, 2023 •
edited
Loading

The 17/27 checks OK message seems to go as far back as #70, I'd say it'd go as back as #68 but #69 has only one test failure.

Failures relating to JS bindings seem to be a preexisting problem unrelated to this PR or #75 and so imo, shouldn't have bearing on the review of this PR.

UdjinM6
UdjinM6 approved these changes May 10, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, test failures look unrelated

PastaPastaPasta
PastaPastaPasta approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 3697c51 into dashpay:develop May 11, 2023
@kwvg kwvg mentioned this pull request May 13, 2023
Closed
5 tasks
@knst knst mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwvg kwvg kwvg approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knst @kwvg @UdjinM6 @PastaPastaPasta