fix: reuse best clsig to avoid potential race condition

[kwvg]

Additional Information

Fix for potential race condition identified by CodeRabbit in dash#6933 (comment)

Breaking Changes

None expected.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas (note: N/A)
• I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
• I have made corresponding changes to the documentation (note: N/A)
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

• backport: merge bitcoin#24595 (move g_versionbitscache global to ChainstateManager) #6933 - backport: merge bitcoin#24595 (move g_versionbitscache global to ChainstateManager)

Please coordinate with the authors of these PRs to avoid merge conflicts.

[kwvg]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Walkthrough

This PR refactors how chain lock information is accessed across three related files. The chainhelper.cpp file updates GetBestChainLockHeight() to use a dedicated accessor method instead of extracting the height from the full chain lock object. The miner.cpp and rawtransaction.cpp files introduce local variables to cache chain lock values, eliminating redundant calls to retrieve the same data. All modifications preserve existing function signatures and behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• All changes follow consistent refactoring patterns: substituting direct accessor methods or caching local variables instead of repeated inline calls
• Three files affected but with straightforward, homogeneous edits
• No control flow modifications, signature changes, or new logic introduced
• Focus areas: verify that the new accessor method (GetBestChainLockHeight()) and cached variables produce equivalent results to the original calls; confirm no performance side effects from the refactoring

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main purpose of the changeset: reusing best_clsig to avoid potential race conditions across three modified files.
Description check	✅ Passed	The description clearly references the related issue and explains the fix is for a potential race condition, directly relating to the changeset's objectives.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4038de and c0faae0.

📒 Files selected for processing (2)

• src/node/miner.cpp (1 hunks)
• src/rpc/rawtransaction.cpp (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• src/rpc/rawtransaction.cpp
• src/node/miner.cpp

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[UdjinM6]

utACK c0faae0