Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zeromq & dashcore-lib #105

Merged
merged 3 commits into from
May 5, 2024
Merged

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented May 5, 2024

Issue

Outdated zeromq package makes project unable to npm install in Node 20+ environments:

#21 73.50 npm ERR! ../../nan/nan.h:2542:19: error: no matching function for call to 'v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>&, void (*&)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&), void (*&)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&), v8::Local<v8::Object>&, v8::AccessControl&, v8::PropertyAttribute&, Nan::imp::Sig&)'

Also, an outdated dashcore-lib package also used that does not support AssetUnlocks.

Things done

  • Updated zeromq package to "@pshenmic/zeromq": "6.0.0-beta.22" (v6 compat + prebuilds)
  • Updated dashcore-lib to "@dashevo/dashcore-lib": "^0.21.1" (latest version)
  • Bump project version to 7.0.4

@pshenmic pshenmic self-assigned this May 5, 2024
lib/services/dashd.js Show resolved Hide resolved
@pshenmic pshenmic merged commit 7203aa1 into dashpay:master May 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants