Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Core 21 #256

Merged
merged 64 commits into from
Aug 6, 2024
Merged

feat: support Core 21 #256

merged 64 commits into from
Aug 6, 2024

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

HashEngineering and others added 29 commits June 25, 2024 09:51
@HashEngineering
Wallet: Fix crash when isAddressMine() is called with a P2SH or a P2W…
cddddd7 
…SH address.

(cherry picked from commit 6b773112773acae56133de9f6ca1881bdbcc36d2)
@HashEngineering
Wallet: remove extra import
c94231d 
Signed-off-by: HashEngineering <[email protected]>
@rustin-bot @HashEngineering
In the tests, change all assertTrue(Arrays.equals()) to assertArrayEq…
955f475 
…uals().

(cherry picked from commit e34766449424524b9999a2542a70aafdf8a84ddb)
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
Don't use the Gradle daemon for running any of the tools.
313a841 
(cherry picked from commit 19fbc76e2f7f1199eb94df43ad457e43425de60f)
Signed-off-by: HashEngineering <[email protected]>
@rustin-bot @HashEngineering
Block: Remove useless null check in writeTransactions().
5dcc781 
(cherry picked from commit 6015c0b98d501186dc87f5223c5df1bcb35cd46b)
@HashEngineering
SPVBlockStore: Explicitly release the store file lock.
881818e 
(cherry picked from commit 0f407cd67eb83af945d7ce0174ca605b9ac31dec)
@HashEngineering
Wallet: Fix NullPointerException in isRequiringUpdateAllBloomFilter()…
d7e4cce 
… when calculating the filter for a basic wallet.

(cherry picked from commit 561bc1d31b90b427f06a63ec24936f720e164951)
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
Wallet: Fix handling of wallet without deterministic chains in checkF…
0266cdf 
…orFilterExhaustion().

(cherry picked from commit 3311ad8cdd947571b7937e13a0fd47f0f31cc6a4)
@HashEngineering
Use plain Gradle console for running any of the tools.
d1aef7b 
(cherry picked from commit db51bb257cc2c18463c38d9f0cf4ec9e18c3cff5)
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
Add test for DnsDiscovery.
59418de 
(cherry picked from commit 3c405931f8039b06e25c698c710b17ec6dac14ad)
@HashEngineering
fix: use mainnet seeder for DnsDiscoveryTest
a8330da 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
Add tests for BtcFixedFormat.
c01c16b 
(cherry picked from commit 19758924160c2b906d08648af21dd135d9d88147)
@HashEngineering
settings.gradle: Prefix project names by 'dashj-'.
03c2e40 
(cherry picked from commit 83b1e44d7d977130d6656f13561be8fd6563c7fa)
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
chore: rename bitcoinj-* to dashj-*; remove leftover pom.xml
58b09e7 
Signed-off-by: HashEngineering <[email protected]>
@matthewleon @HashEngineering
KeyCrypterScrypt: Migrate AESFastEngine to AESEngine.
87797d4 
AESFastEngine raises a deprecation warning. See https://nvd.nist.gov/vuln/detail/CVE-2016-1000339

(cherry picked from commit 89fd7a89ced142001722d7123ce5cf7efd3f8c55)
Signed-off-by: HashEngineering <[email protected]>
@matthewleon @HashEngineering
Avoid use of deprecated Throwables.propagate().
719d839 
(cherry picked from commit de8a1f755b8dbaf73aa482b7636a47538dfe5ec4)
@matthewleon @HashEngineering
WalletProtobufSerializer: Eliminate use of deprecated Protos.Transact…
f42c627 
…ionConfidence.Type.valueOf().

(cherry picked from commit e94fbe4403818ea35b51edf5e70f40a2e6d50d40)
@matthewleon @HashEngineering
KeyChainGroup: Fix NullPointerExceptions in encrypt() for the case of…
be8a4fe 
… only a basic keychain.

(cherry picked from commit 4ed5b0e3b06c18040d83be30df32e7be5b778b51)
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
fix: AnyKeyChainGroup: Fix NPEs in encrypt() for the case of only a b…
c15ca45 
…asic keychain.

Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
KeyChainGroupTest: Extract AES_KEY used in tests to constant because …
e73370b 
…deriving the key is costly.

(cherry picked from commit 19ce48afd9a014ba9662f59d241775c4708917e5)
Signed-off-by: HashEngineering <[email protected]>
@oscarguindzberg @HashEngineering
WalletAppKit: Clear the blockchain file (as opposed to delete it) in …
d10e49f 
…preparation for restore.

This adds a new clear() method to SPVBlockStore.

(cherry picked from commit 6c944f41422751bf98aed260377d38be3ef9e486)
Signed-off-by: HashEngineering <[email protected]>
@oscarguindzberg @HashEngineering
PeerGroup.triggerConnectionsJob: Code cleanup.
27b447e 
(cherry picked from commit 52804fc8ce27475409a0d9f33348835e0a0a839a)
@rustin-bot @HashEngineering
ProtobufConnection: Make message length check more readable.
edb9c1b 
(cherry picked from commit 70ac9208450f6d7a11cceb5a19da6492cf6020f9)
@matthewleon @HashEngineering
Wallet: Eliminate a redundant null check.
1818d67 
(cherry picked from commit 9b934ebcde19d2d9cde2a95a0d734920718b5778)
Signed-off-by: HashEngineering <[email protected]>
@matthewleon @HashEngineering
KeyChainGroup: Be smarter about encryption order.
143da56 
This partly reverts commit 4ed5b0e3b06c18040d83be30df32e7be5b778b51.

(cherry picked from commit 5570b0b47639e4a1210ca317a69a0c49549404cc)
@HashEngineering
Speed up tests with Scrypt and reduce memory consumption by reducing …
018bef6 
…the number of iterations.

(cherry picked from commit 0df0591c0b1ad6fbd20861e98e68146ed4851c64)
Signed-off-by: HashEngineering <[email protected]>
@msgilligan @HashEngineering
Replace Guava primitive compare() with JDK7+ compare().
9e8bc19 
In Java 7, Integer.compare() and Long.compare() were added. Use those
methods rather than the Guava equivalents which are “deprecated” for
JDK7+.

(cherry picked from commit 56443ee7542856af93e2411145e82cfea87152c8)
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
DeterministicSeed: New method getMnemonicString() to do the string co…
ed21434 
…ncatenation.

(cherry picked from commit 6b309e486f23e9bf9bcbfd17d501bc6b6af279fc)
@msgilligan @HashEngineering
Use JDK7+ Objects.hash() and equals() rather than the Guava variants.
252eef5 
The Guava variants are “deprecated” for JDK7+.

(cherry picked from commit 686a10ccd2c6bd06a7c785e1c637b611a6b8c0d0)
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering HashEngineering self-assigned this Jul 6, 2024
@HashEngineering
chore: update seed lists for mainnet and testnet from Core 21
f3209d3 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: improve the BLS Lazy classes
18a9712 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: improve the AbstractDiffMessage class
59f3ef1 
* use auto close on a stream

Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: make all constructors abstract in AbstractQuorumRequest
b21d913 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: remove unused fields in ChainLocksHandler
36b3b59 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: add @OverRide and license to ChainLockSignature
a8c9fa3 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: use diamond <> for implied template parameters
d7953b6 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: remove deprecated methods in InstantSendManager
2726331 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
tests: fix and simplify some tests in DnsDiscoveryTest and ChainLocks…
1467ffa 
…HandlerTest

Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: make all fields private in MasternodeListDiffException
e336419 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: remove deprecated methods and simplify some getters in Quor…
873a1a6 
…umRotationInfo

Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
fix: fix equals in FinalCommitment and refactor some
2204cb1 
* add hashCode

Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: make one field final in GetSimplifiedMasternodeListDiff
313b581 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: remove deprecated methods and simplify getters in Simplifie…
ec3191d 
…dMasternodeListManager

Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: make atomic fields final in QuorumUpdateRequest
7b25bea 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: simplify some code in QuorumState
887f08a 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
chore: remove commented code and deprecated methods in QuorumRotation…
62794f8 
…State

Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: remove deprecated methods and constants and simplify Simpli…
27ab88b 
…fiedMasternodeListDiff

Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: remove deprecated methods and constants and simplify Simpli…
6be4827 
…fiedMasternodeList

Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: make field final in SimplifiedMasternodeListEntry
711ecb1 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: use lamdas and simplify SimplifiedQuorumList
8d498e6 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: make constructors protected in SpecialTxPayload
9439bb7 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
tests: update mnlistdiff related tests
b6e2633 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: use <> in MasternodeMetaDataManager
d622b2c 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: use <> in GovernanceObject
2c8bd40 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering
refactor: make bootStrapLoaded private and add a getter
a559bca 
Signed-off-by: HashEngineering <[email protected]>
@HashEngineering HashEngineering mentioned this pull request Jul 12, 2024
Merged
3 tasks
@HashEngineering HashEngineering merged commit d6b256d into master Aug 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HashEngineering HashEngineering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HashEngineering @rustin-bot @matthewleon @oscarguindzberg @msgilligan